Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exrcheck: rework 'reduceMemory' and 'reduceTime' modes #902

Merged
merged 3 commits into from
Jan 28, 2021
Merged

exrcheck: rework 'reduceMemory' and 'reduceTime' modes #902

merged 3 commits into from
Jan 28, 2021

Conversation

peterhillman
Copy link
Contributor

Better handling of reduceMemory and/or reduceTime flags in checkOpenEXRFile method or exrcheck utility:

  • in reduceTime mode, each test now returns immediately when it encounters an exception, rather than skipping scanlines/tiles. Files which are large on disk may now take longer to read, but are more thoroughly tested. Small files will fail faster.
  • reduceMemory mode now estimates the amount of memory required to read an entire scanline of tiles when using the scanline API for tiled images (tiled images with large tile heights require large memory allocations in the intermediate buffer)
  • magic numbers used for time/memory limits are now constants

Adresses:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29393
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29682

Signed-off-by: Peter Hillman peterh@wetafx.co.nz

@peterhillman
exrcheck: rework 'reducememory' and 'reducetime' modes
ee730ff 
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
cary-ilm approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm
Copy link
Member

It looks like there are conflicts from the recent enum changes that need to be resolved, the merge isn't trivial.

@cary-ilm cary-ilm merged commit dca8079 into AcademySoftwareFoundation:master Jan 28, 2021
@peterhillman peterhillman mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
oss-fuzz v3.0.0-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhillman @cary-ilm